When casting display the CL of the spell in combat log

Items currently acknowledged by staff for fixing/further staff discussion (Only staff should put threads here to avoid confusion)

Moderators: Moderator, Quality Control, Developer, DM

User avatar
mrm3ntalist
Retired Staff
Posts: 7712
Joined: Wed Feb 29, 2012 5:31 pm
Location: Skala Kallonis, Lesvos, Greece

Re: When casting display the CL of the spell in combat log

Unread post by mrm3ntalist »

EasternCheesE wrote: Tue May 24, 2022 6:32 pm
mrm3ntalist wrote: Tue May 24, 2022 9:41 am Can you test the cl of a build with dragon disciple ? My builds with that prc get 2cl more than they should. I made a post about that months ago and I was I told it was fixed, however my builds still get the bonus cl
This one is fixed in next update, i found the offending code and changed it to working one.
On the main topic, there is no resolution yet as i seek for the way to avoid running through every spell script to check it.
I am glad. I mentioned this almost a year ago, but nothing got done. I am surprised no-one else noticed. BTW the CL message displayed at the log window already helps alot, even if it is not correct for things such as SLAs
IS EMOTIONAL KEKW - GIT GUD

Mendel - Villi of En Dharasha Everae | Nikos Berenicus - Initiate of the Mirari | Efialtes Rodius - Blood Magus | Olaf Garaeif - Dwarven Slayer

Spelling mistakes are purposely entered for your entertainment!
EasternCheesE
QC Coordinator
Posts: 1921
Joined: Sat Jul 28, 2018 8:51 am

Re: When casting display the CL of the spell in combat log

Unread post by EasternCheesE »

mrm3ntalist wrote: Tue May 24, 2022 9:29 pm
EasternCheesE wrote: Tue May 24, 2022 6:32 pm
mrm3ntalist wrote: Tue May 24, 2022 9:41 am Can you test the cl of a build with dragon disciple ? My builds with that prc get 2cl more than they should. I made a post about that months ago and I was I told it was fixed, however my builds still get the bonus cl
This one is fixed in next update, i found the offending code and changed it to working one.
On the main topic, there is no resolution yet as i seek for the way to avoid running through every spell script to check it.
I am glad. I mentioned this almost a year ago, but nothing got done. I am surprised no-one else noticed. BTW the CL message displayed at the log window already helps alot, even if it is not correct for things such as SLAs
As i checked our commit log, other Dev did actually fix it in july of 2021, but they seem have been too used to python syntactic sugar, so they wrote their code using it which kinda doesn't work in nwnscript :P

Agreed, i found it really useful. Since we already removed that feature from live, i had to manually add it for my local testing setup in order to troubleshoot which exact part was failing. Btw, you correctly identified the source of issue - it was dragon disciple giving 9 progression instead of 7 at lvl 10, because condition block never triggered it's right part since nwnscript doesn't support ( n < Var < n) style of comparisons.
User avatar
Hullack
Recognized Donor
Posts: 135
Joined: Tue May 03, 2022 4:56 pm

Re: When casting display the CL of the spell in combat log

Unread post by Hullack »

Image

Penetrating Blasts seems to have a similar bug.
Jak Dimburrow : House Vale (Character Biography/Journal)
Playtimes: 7:30 PM - 11:00 PM Eastern Standard Time (EST) / UTC/GMT -5
Items Wanted and Offered in Exchange
User avatar
Rhifox
Retired Admin (Acting Assistant Admin)
Posts: 3711
Joined: Wed Jan 13, 2016 2:34 am

Re: When casting display the CL of the spell in combat log

Unread post by Rhifox »

Hullack wrote: Wed May 25, 2022 10:18 am Image

Penetrating Blasts seems to have a similar bug.
Not a bug. Penetrating Blasts gives +4 to CL for the purposes of spell penetration.

Although, looks like this value might be getting used on spell properties dependent on caster level rather than just penetrating SR. Hmm.
Tarina — Witch, Apothecary, Dealer in Spirits and Black Magic
User avatar
Rinzler
Recognized Donor
Posts: 507
Joined: Thu Aug 03, 2017 10:50 pm
Location: Discord: rinzler#3004

Re: When casting display the CL of the spell in combat log

Unread post by Rinzler »

Has this been fixed?
EasternCheesE
QC Coordinator
Posts: 1921
Joined: Sat Jul 28, 2018 8:51 am

Re: When casting display the CL of the spell in combat log

Unread post by EasternCheesE »

Rinzler wrote: Tue Jun 21, 2022 7:36 pm Has this been fixed?
Not yet. Won't be fixed in next patch as making such thing right would require me to rewrite our spellcasting framework (and it's something i plan to do). So i didn't make some bandaid and just focused on next patch. After it, i will come to this topic.
User avatar
mrm3ntalist
Retired Staff
Posts: 7712
Joined: Wed Feb 29, 2012 5:31 pm
Location: Skala Kallonis, Lesvos, Greece

Re: When casting display the CL of the spell in combat log

Unread post by mrm3ntalist »

Was this removed? I no longer see the CL. It is extremely helpful for the Rcr
IS EMOTIONAL KEKW - GIT GUD

Mendel - Villi of En Dharasha Everae | Nikos Berenicus - Initiate of the Mirari | Efialtes Rodius - Blood Magus | Olaf Garaeif - Dwarven Slayer

Spelling mistakes are purposely entered for your entertainment!
EasternCheesE
QC Coordinator
Posts: 1921
Joined: Sat Jul 28, 2018 8:51 am

Re: When casting display the CL of the spell in combat log

Unread post by EasternCheesE »

Yes, it was removed because proper implementation requires us rewriting our magic system. Once it's done, it will be back.
User avatar
mrm3ntalist
Retired Staff
Posts: 7712
Joined: Wed Feb 29, 2012 5:31 pm
Location: Skala Kallonis, Lesvos, Greece

Re: When casting display the CL of the spell in combat log

Unread post by mrm3ntalist »

EasternCheesE wrote: Sat Jul 02, 2022 11:02 am Yes, it was removed because proper implementation requires us rewriting our magic system. Once it's done, it will be back.
Thank you
IS EMOTIONAL KEKW - GIT GUD

Mendel - Villi of En Dharasha Everae | Nikos Berenicus - Initiate of the Mirari | Efialtes Rodius - Blood Magus | Olaf Garaeif - Dwarven Slayer

Spelling mistakes are purposely entered for your entertainment!
Post Reply

Return to “Currently Under Review”