Ranger's favored enemy is not working with shield bash

[ARHicks00]

The favor damage is not stack with normal shield bash. Only with the main handed.

[Valefort]

Plenty of damage sources do not work with shield bash. Adding them all is a monumental and hopeless task in my opinion so I'll decline adding this particular damage source, sorry.

[blacksoft]

Plenty of damage sources do not work with shield bash. Adding them all is a monumental and hopeless task in my opinion so I'll decline adding this particular damage source, sorry.

So when it comes to shield bash damage, each damage source has to be coded on separately? If so, that sucks. I thought non-weapon applied damage sources (i.e. damage applied to character) was automatic.

[Valefort]

For "real" weapons yes, however shield bash is a script that applies damage and not a weapon so things have to be added manually.

[chad878262]

Shield Bash also does not apply sneak attack damage which it says it does. As Valefort says though for these custom functionalities that are heaped in spaghetti code I think the proper approach is simply to update the wiki and if necessary in game description of the feat rather than to ask a developer to go hunting for needles in a gigantic haystack. Simply put there are plenty of other things that will have greater impact with far less frustration. If some individual *WANTS* to go through the Shield Bash code to work out how to apply different damage types they can certainly contact Endelyon and see if she can provide it to you. Then if you come up with a fix that you are able to test in your own server you can submit it back for review. This is in no way a promise that this approach is acceptable, simply a statement that in general if you want a specific mechanic implemented or modified a possible approach is to offer to do the work yourself.

I say this because we have so much custom content that has been implemented by countless developers, many who are no longer around or paying attention to the forums or the game. This makes it very difficult for others to reverse engineer and fix previously implemented functionality.

[Valefort]

And there's also the question, is that even a desireable change ? Shield bash is already rather good as it is.

[Theodore01]

Shield bash is already rather good as it is.

good one