Weapon Mastery (Unarmed) & Monk Improved Grapple

[Jrgdouble0]

Hi!

Had been testing a build on JEGS when I noticed:

1. Weapon Mastery (Unarmed) was not providing the +2 AB increase. (Sorry, it only occurs to me now I didn't confirm whether it was providing the +2 damage, but I assume not.)

2. Improved Grapple (when selected at Monk Level 6 specifically) didn't work. Choosing Improved Grapple at Monk 6 will grant the feat to your list of feats located in the character sheet, but the basic, non-improved Grapple remains in that list as well. Improved Grapple is then slottable, but *not usable.* You can only use basic Grapple. Further, Improved Grapple remains selectable upon further level-ups normally as a feat, at which point if you choose it, then (and only then) basic Grapple removed from your character sheet, and Improved Grapple properly activates and provides it's bonus when slotted.

I'm not sure if these issues are reflected on the main server since I'm pretty new to all this, but thank you!

[Jrgdouble0]

Small update: Mastery doesn't apply it's damage bonus either.

[EasternCheesE]

Unarmed mastery is hardcoded feat, so it's unlikely we can do anything in its regard.
Speaking of improved grappling, these new feats are made so improved versions are just placeholder feats used to detect by scripts and you just keep using regular grapple with bonus added automatically. I fixed scripting to detect monk improved grapple (for technical reasons it has to be different feat from improved grapple, though having both does only give bonus once) and it will work in next update.

[Dmitri]

Unarmed mastery is hardcoded feat, so it's unlikely we can do anything in its regard.

Pretty sure this is a Kaedrin feat : Weapon Mastery (Unarmed)

It used to work on the server, but currently does not work.

It works on the offline module version of JEGS which is associated with BGTSCC, albeit somewhat out of date.

Please can we get this looked at?

The AB bonus is not working, which can be calculated between analysing the character sheet, combat logs and the numbers for the build on paper.

The bonus 2 damage should show on character sheet when unarmed (in the same way that the other weapon mastery feats work).

[EasternCheesE]

I looked into it and, sadly, detecting PC being in the middle of hitting something (and in combat in general) is quite a hassle.
Unfortunately, we can't make this AB bonus being not subject to +20 cap even if we ever make a workaround for it to be detected.

I will look more into workarounds some time later.

[DaloLorn]

I looked into it and, sadly, detecting PC being in the middle of hitting something (and in combat in general) is quite a hassle.
Unfortunately, we can't make this AB bonus being not subject to +20 cap even if we ever make a workaround for it to be detected.

I will look more into workarounds some time later.

... You did notice me committing a fix, right?

It was my fault (as is the case with an alarming amount of bugs these days, apparently). I was consolidating a bunch of weapon mastery functions and I missed a NOT operator when checking if the offhand slot was empty. As a result, Unarmed Mastery would only work if you had something in your offhand slot (but not your mainhand, so it had to be a shield or torch), versus the previous behavior of only working if both your hands were empty.

[EasternCheesE]

I looked into it and, sadly, detecting PC being in the middle of hitting something (and in combat in general) is quite a hassle.
Unfortunately, we can't make this AB bonus being not subject to +20 cap even if we ever make a workaround for it to be detected.

I will look more into workarounds some time later.

... You did notice me committing a fix, right?

It was my fault (as is the case with an alarming amount of bugs these days, apparently). I was consolidating a bunch of weapon mastery functions and I missed a NOT operator when checking if the offhand slot was empty. As a result, Unarmed Mastery would only work if you had something in your offhand slot (but not your mainhand, so it had to be a shield or torch), versus the previous behavior of only working if both your hands were empty.

Unless you did stuff somewhere else, i was talking about feat_melee_strike spaghetti code that is somehow called when PC is in attack_mode. And no, i didn't see you commiting a fix

[DaloLorn]

Where the hell did you even dig that up?

That script seems to govern a pile of things, but none related to the issues reported in the OP...

[EasternCheesE]

Where the hell did you even dig that up?

That script seems to govern a pile of things, but none related to the issues reported in the OP...

It refers to unarmed mastery feat ID and provides respective bonuses so i assumed it was what governs it