Lawful Sword Doesn't Stick

[RedLancer]

Per the subject, you cast, and shortly after casting, it goes away.

[Afendaria]

Related, perhaps - But I've noticed Bless Weapon seems.. pathetically short lately too. Did something happen to Paladin based spells?

[Goat]

Nothing was changed with spell duration on all paladins spells - no. Each spell would have to be modified manually for the duration but nothing was changed of the sort.

If it's removing on unequip or something there is probably something strange happening. I believe there are some cases that trigger the removal, I don't know what's been going on about it. I think it was brought up before and AoS was going to investigate it. Unequip is defo one of them and there is probably a reason why it exists there.

Code: Select all

// Removes all weapon buffs.  Called on unequip of weapon and when trying to apply a weapon buff while currently ranged.
void RemoveAllWeaponBuffs(object oPC)
{
	RemoveBfix(oPC, BLESS_WEAPON);
	RemoveBfix(oPC, HOLY_SWORD);
	RemoveBfix(oPC, LAWFUL_SWORD);
	RemoveBfix(oPC, UNHOLY_SWORD);
	RemoveBfix(oPC, FLAME_OF_FAITH);
	RemoveBfix(oPC, DEAFENING_CLANG);
	RemoveBfix(oPC, DISRUPTING_WEAPON);
	RemoveBfix(oPC, FROST_WEAPON);
	RemoveBfix(oPC, ORC_BLOODSPEAR);
	RemoveBfix(oPC, WATERY_DEATH);
	RemoveBfix(oPC, WEAPON_OF_DESTRUCTION);
	RemoveBfix(oPC, FLAME_WEAPON);
}

Mostly these. The problem is the information is so vague, I can assume that something happens where the buff stays 'stuck' for some reason.

[RedLancer]

There was an issue called out in September-ish re: weapon buffs not playing nice with each other, something like Bless Weapon had to go on last, and a fix was attempted.

Just did some testing: the weapon buff is being stripped on the equip/unequip of any item, not just the buffed weapon. Put on a shield? Buff gone. Change a ring? Buff gone. And so on. This is also stripping Holy Sword; I just never noticed because I'm usually done swapping items by the time Holy Sword goes up.

[Mork]

I can confirm about holy sword and some others. Reported it earlier here:
viewtopic.php?p=978192

Super annoying when combined with disarming mimics

[Goat]

There was an issue called out in September-ish re: weapon buffs not playing nice with each other, something like Bless Weapon had to go on last, and a fix was attempted.

Just did some testing: the weapon buff is being stripped on the equip/unequip of any item, not just the buffed weapon. Put on a shield? Buff gone. Change a ring? Buff gone. And so on. This is also stripping Holy Sword; I just never noticed because I'm usually done swapping items by the time Holy Sword goes up.

Huh. That's interesting. I guess that's why some buffs I have had are randomly removed when I stripped naked and ran through the streets of Soubar.

I think Dae made a change in September though yes.

[Goat]

I can confirm about holy sword and some others. Reported it earlier here:
viewtopic.php?p=978192

Super annoying when combined with disarming mimics

I've noticed Holy Sword gets dispelled on weapon change, same happens when you are disarmed. I heard it was suppose to be a method to prevent people from buffing weapon and posting it on auction? Way it's implemented now seems very buggy and causing a lot of issues for normal players.

Also there's a problem with Keen and GMW when weapon is disarmed by mimic. Their sticky tongues shouldn't have dispelling property

This actually happens because there's a problem with disarm and there wasn't a code solution for it. The buffs become permanent sometimes. From what I know it was a change by GED awhile back and getting disarmed has always removed buffs in this scenario. There is no real easy way around this one atm unless maybe Dae can make something of a plugin - But it shouldn't be randomly removing all buffs if you change a shield for example. I don't think the disarm dispel is going to be fixed anytime soon to be blunt but it was nothing to do with auction sales.

But the one RL posted is something new, and I can see it based on r245 too.

[ValerieJean]

I'm planning to do some testing tonight because I've run into similar issue on gaven and it's awfully frustrating. I'll have AoS help.

[RedLancer]

Just did some testing: the weapon buff is being stripped on the equip/unequip of any item, not just the buffed weapon. Put on a shield? Buff gone. Change a ring? Buff gone. And so on. This is also stripping Holy Sword; I just never noticed because I'm usually done swapping items by the time Holy Sword goes up.

This is it. The script is firing on any equip/unequip.

[Goat]

I removed the changes from r245 so next update test it for now. It might require you using bless weapon last again or whatever the previous issue was. But it was causing too much issues and the fix is a bit complicated. It was also stripping druids too, so simply removing buffs on just the weapons would still strip them on morph, so its a bit annoying. The previous was still better then what is currently going on.

AoS said he will look at it, but it will at least reduce the headache until he does.

Edit: Oh there was a heavier change, I am going to revert the functionality of it but try to keep some other things for code cleanliness.

It honestly seems slightly buggy, but it does work. AKA Lawful sword seems to be needed to be cast first. Bless weapon last, etc. It's weird. We'll have to look It should be removing the buffs on the weapons on removal (Holy Sword) But half does. It's a little messy and how GED solved it on disarm isn't how I want to do it here.

[Goat]

I made some changes to this. Campaign r412.

It should fix a various amount of things - including not having to do specific spell orders, unequipping bugs, and other things.

Theres probably additional spells that could be placed on this (Maybe EB enhancing ones and whatever) but for now it's fine. Let me know how it goes when it's live sometime next week.