Page 2 of 2
Re: Northlander Hewing Critical Strike Damage Calculation
Posted: Fri Oct 14, 2022 6:55 am
by mrm3ntalist
Ewe wrote: ↑Fri Oct 14, 2022 12:34 am
I think there’s not enough information to explain the root cause exactly and may be caused by something else. I’m merely trying to help. I don’t deserve the snippy attitude.
What else can there be? You can see the weapon damage source and the max damage it can do and the results in the combat log. What "other" sources can there be? You could simply test the feat and see for yourself. Most that posted here actually did test the feat ingame
Re: Northlander Hewing Critical Strike Damage Calculation
Posted: Fri Oct 14, 2022 7:02 am
by Rhifox
Ewe is our engine-level developer. He handles programming at the hardcoded level. So I would appreciate you not speaking like he's someone that doesn't know what he's doing. The underlying code for the function imply that it isn't able to crit. If it is critting in spite of that, then that's something to look into regarding why. But the hostile language is really unnecessary.
Re: Northlander Hewing Critical Strike Damage Calculation
Posted: Fri Oct 14, 2022 7:28 am
by mrm3ntalist
Rhifox wrote: ↑Fri Oct 14, 2022 7:02 am
Ewe is our engine-level developer. He handles programming at the hardcoded level. So I would appreciate you not speaking like he's someone that doesn't know what he's doing. The underlying code for the function imply that it isn't able to crit. If it is critting in spite of that, then that's something to look into regarding why. But the hostile language is really unnecessary.
I do not think we ever discussed ewes skills here. We were discussing a specific matter (nh). I took the time to log in game and test it, take screenshots and post it here instead of theory crafting. It is as simple as that and everyone with access to the game can do it. Ewe could do simply do that and see it for himself.
Two other players that posted here did just that. Tested it and came to the same conclusion
Re: Northlander Hewing Critical Strike Damage Calculation
Posted: Fri Oct 14, 2022 7:56 am
by Ewe
I spent a couple days stepping through x32dbg attached to the server process and reverse engineered some of the effects system in order to figure out which hex values to change to jump over the cpu instructions which cause the 100 effect increase damage cap calculations. Then I spent another day conducting in-game unit testing on the fix before handing off the engine mod to Rhifox to install on the server.
Given that the cap was the root cause of the OP's original complaint and if NH is intended to crit I think we can just close out this investigation.
Re: Northlander Hewing Critical Strike Damage Calculation
Posted: Fri Oct 14, 2022 8:04 am
by mrm3ntalist
Did you find whether NH currently crits?
Re: Northlander Hewing Critical Strike Damage Calculation
Posted: Fri Oct 14, 2022 8:08 am
by Steve
Ewe wrote: ↑Fri Oct 14, 2022 7:56 am
I spent a couple days stepping through x32dbg attached to the server process and reverse engineered some of the effects system in order to figure out which hex values to change to jump over the cpu instructions which cause the 100 effect increase damage cap calculations. Then I spent another day conducting in-game unit testing on the fix before handing off the engine mod to Rhifox to install on the server.
Given that the cap was the root cause of the OP's original complaint and if NH is intended to crit I think we can just close out this investigation.
A wizard in the workshop!!
Re: Northlander Hewing Critical Strike Damage Calculation
Posted: Fri Oct 14, 2022 9:10 am
by mrm3ntalist
BTW here is another source of bludgeoning damage that crits ( Deadly Defense )
Re: Northlander Hewing Critical Strike Damage Calculation
Posted: Fri Oct 14, 2022 9:35 am
by Ewe
I don't know offhand, it will take considerable research to see what's going on here.
I just know in the stock engine this does not crit, you can read more about this bug on the nwn2 wiki here:
https://nwn2.fandom.com/wiki/EffectDamageIncrease
Re: Northlander Hewing Critical Strike Damage Calculation
Posted: Fri Oct 14, 2022 9:40 am
by mrm3ntalist
Ewe wrote: ↑Fri Oct 14, 2022 9:35 am
I don't know offhand, it will take considerable research to see what's going on here.
its the main hand. I can reproduce this with one weapon as well.
Anybody that plays monks, does their damage crit as well?
Re: Northlander Hewing Critical Strike Damage Calculation
Posted: Fri Oct 14, 2022 9:54 am
by mrm3ntalist
When NH matches the base damage, it still crits
Re: Northlander Hewing Critical Strike Damage Calculation
Posted: Fri Oct 14, 2022 10:12 am
by mrm3ntalist
I wouldn't take the wiki articles at its face value, at least not without some testing. There are many inconsistencies, especially for a mature server like BG where many changes were implemented. At the end of the day, all tests indicate that the NH extra damage, crits with any possible combination.